Skip to content

fix(app): simplify session tab status dots to 4 states - #237

Merged
jeonghun-jj-lee merged 1 commit into
local/amicodefrom
simplify-tab-status-dots
Aug 23, 2026
Merged

fix(app): simplify session tab status dots to 4 states#237
jeonghun-jj-lee merged 1 commit into
local/amicodefrom
simplify-tab-status-dots

Conversation

@jeonghun-jj-lee

@jeonghun-jj-lee jeonghun-jj-lee commented Aug 23, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Simplifies the session tab status dots from 5 states to 4 with clearer semantics:

Dot Meaning
Green Done — unread output
Grey Done — already seen
Yellow Running
Red Error

Changes

  • Status logic — removed attention state; needsAttention now folds into done (green) since both mean "your turn"
  • Colors — running changed from blue to yellow (#ca8a04 light / #eab308 dark) for better contrast against red
  • Dropdown — only shows a dot for sessions that are open as tabs; closed sessions have no indicator
  • CSS — removed --status-attention, added --status-idle (grey for seen sessions)
  • Tests — updated to match new precedence rules

Summary by CodeRabbit

  • UI Improvements
    • Updated session status indicators with clearer, consistent colors across light and dark themes.
    • Status dots now appear only for sessions opened as tabs, reducing visual clutter.
    • Simplified status categories to idle, running, done, and error.
    • Error status now takes priority over running or completion indicators, while completed sessions display the done state.

@jeonghun-jj-lee
fix(app): simplify session tab status dots to 4 states
949c5b1 
Reduce from 5 states to 4 with clearer semantics:
- green: done, unread
- grey: done, already seen
- yellow: running
- red: error

Dropdown only shows dots for sessions with open tabs. Idle sessions
without open tabs show no indicator.
@jeonghun-jj-lee
jeonghun-jj-lee merged commit 1d384b8 into local/amicode Aug 23, 2026
1 of 3 checks passed
@coderabbitai

coderabbitai Bot commented Aug 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 6a43a213-2e8a-4415-a2b9-d96d3366eeb1

📥 Commits

Reviewing files that changed from the base of the PR and between 7527d32 and 949c5b1.

📒 Files selected for processing (4)
  • packages/app/src/components/session/session-header.tsx
  • packages/app/src/design-polish.css
  • packages/app/src/pages/layout/session-tab-status.test.ts
  • packages/app/src/pages/layout/session-tab-status.tsx
📝 Walkthrough

Walkthrough

The session status model now has four states with updated precedence and color tokens. Session rows memoize the shared status and show the status dot only for open tabs. Tests cover the revised state resolution.

Changes

Session status display

Layer / File(s) Summary
Update status states and precedence
packages/app/src/pages/layout/session-tab-status.tsx, packages/app/src/pages/layout/session-tab-status.test.ts, packages/app/src/design-polish.css		 Removes the attention state. Errors take precedence over running, and completion conditions return done. Light and dark status colors use yellow, green, grey, and red tokens. Tests cover the new precedence.
Apply status rendering to session rows
packages/app/src/components/session/session-header.tsx		 SessionDropdownRow derives a memoized status from shared avatar state and renders the status dot only for open tabs.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: kateebonner

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch simplify-tab-status-dots

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jeonghun-jj-lee